Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose iso3166 in the result #40

Closed
wants to merge 1 commit into from
Closed

expose iso3166 in the result #40

wants to merge 1 commit into from

Conversation

zaggino
Copy link

@zaggino zaggino commented Apr 12, 2016

Hi, we need to access the data in iso3166 to get the country_code from the result. Exposing the whole iso3166 would not break the API and is a bit more flexible for potential other needs.

@teddychan
Copy link
Member

Sorry I can't merge this:

coz currently the function will only return

  1. []
  2. [element1, element2]
    so most obvious different between normal result and error result is
    result.length = 0 and result.length = 2
    i.e. reasonable that user use the result.length == 2 (or result.length > 0) to check if it’s valid
    therefore not recommended to merge this directly

You may forked it to support your own use case first.
but i will keep this as features request in v2 version

@teddychan teddychan closed this May 5, 2016
@teddychan teddychan mentioned this pull request May 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants