Fix missing header without LZO #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alyssais
commented
Apr 1, 2020
alyssais
commented
lib/common/compress.c: In function 'compressor_get_default':
lib/common/compress.c:39:2: warning: implicit declaration of function 'assert' [-Wimplicit-function-declaration]
39 | assert(0);
| ^~~~~~
lib/common/compress.c:8:1: note: 'assert' is defined in header '<assert.h>'; did you forget to '#include <assert.h>'?
7 | #include "common.h"
+++ |+#include <assert.h>
8 |
alyssais
added a commit
to alyssais/nixpkgs
that referenced
this pull request
Apr 1, 2020
Like all supported formats (I think), LZO is optional. I don't see any reason to bother with options for now, so I've just enabled it. Plus, there's a bug in this release that makes compilation fail if LZO is disabled due to a missing include. I've sent a fix[1] for that upstream. [1]: AgentD/squashfs-tools-ng#41
10 tasks
alyssais
added a commit
to NixOS/nixpkgs
that referenced
this pull request
Apr 2, 2020
Like all supported formats (I think), LZO is optional. I don't see any reason to bother with options for now, so I've just enabled it. Plus, there's a bug in this release that makes compilation fail if LZO is disabled due to a missing include. I've sent a fix[1] for that upstream. [1]: AgentD/squashfs-tools-ng#41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.