Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1860 adding tests for the executor resource deployment files #1893

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

Aravind-psiog
Copy link
Collaborator

@Aravind-psiog Aravind-psiog commented Dec 22, 2023

  • I have added the tests to cover my changes.
  • I have updated the documentation and CHANGELOG accordingly.
  • I have read the CONTRIBUTING document.

@Aravind-psiog Aravind-psiog self-assigned this Dec 22, 2023
@Aravind-psiog Aravind-psiog requested a review from a team as a code owner December 22, 2023 08:44
@Aravind-psiog Aravind-psiog linked an issue Dec 22, 2023 that may be closed by this pull request
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8d22e7d) 84.52% compared to head (9fb23bb) 85.26%.

❗ Current head 9fb23bb differs from pull request most recent head 978988a. Consider uploading reports for the commit 978988a to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1893      +/-   ##
===========================================
+ Coverage    84.52%   85.26%   +0.74%     
===========================================
  Files          295      181     -114     
  Lines        14488    11267    -3221     
  Branches       195        0     -195     
===========================================
- Hits         12246     9607    -2639     
+ Misses        2108     1660     -448     
+ Partials       134        0     -134     
Flag Coverage Δ
Dispatcher 92.47% <ø> (-0.06%) ⬇️
Functional_Tests ?
SDK 79.81% <ø> (+0.31%) ⬆️
UI_Backend ?
UI_Frontend ?

@Aravind-psiog
Copy link
Collaborator Author

@kessler-frost @araghukas It appears that the test coverage for the cloud_resource_manager is at a satisfactory 96%. However, the coverage for the cli groups are at 55%. The local coverage for this was improved by installing plugins, but these changes have not been pushed to the repository because the CI environment does not install plugins, resulting in test failures.

@santoshkumarradha santoshkumarradha removed the request for review from araghukas December 29, 2023 02:15
tests/covalent_tests/cloud_resource_manager/core_test.py Outdated Show resolved Hide resolved
tests/covalent_tests/cloud_resource_manager/core_test.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding tests for the Executor Resource Deployment files
3 participants