Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Several Black Rectangles Appearing #91

Closed
geotraveler opened this issue Dec 7, 2020 · 5 comments
Closed

[BUG] Several Black Rectangles Appearing #91

geotraveler opened this issue Dec 7, 2020 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@geotraveler
Copy link

geotraveler commented Dec 7, 2020

Describe the bug

This note came from BigStep who has been working with us to extend the plugin after they troubleshooted the root cause:

"The issue is coming when there is an interruption in the internet connection, i.e., if the user's internet connection is affected then the peer leaves, in the plugin the div is not getting closed. This issue is in the core plugin."

To Reproduce
Steps to reproduce the behavior:

Several hosts can connect to a broadcast. When one of them drops (or internet disconnects), the black rectange keeps hanging and sometimes when the host reconnects, they are hidden behind the black rectangle and a tiny bit visible underneath.

For example 3 hosts, A, B, C - If C gets disconnected and reconnects, then there are 4 videos, with one black rectangle where C used to be and the new C video. If it happens again to C, then there are 5 videos with two black rectangles, and it goes on and on.

Expected behavior
When a host leaves, only the remaining hosts should remain on the screen. Not a black rectangle where the host was before they left or were abruptly disconnected.

Screenshots
See attached screenshots

Desktop (please complete the following information):

  • OS: Windows
  • Browser: Chrome, Safari, Edge

Agora Bug 1
Agora Bug

@geotraveler geotraveler added the bug Something isn't working label Dec 7, 2020
@digitallysavvy
Copy link
Contributor

It looks like this is a side effect of adding the logic in #85 to keep the channel from closing if the broadcaster drops out due to poor connection.

There needs to be some logic added to clean up the UI if broadcaster leaves the channel so when they rejoin the Ui displays as expected.

@geotraveler
Copy link
Author

That is what BigStep is working on for us, but isn't this something you would need to add to the base functionality of the core plugin?

@digitallysavvy
Copy link
Contributor

Yes this would be a core functionality to the plugin.

@digitallysavvy digitallysavvy mentioned this issue Jan 18, 2021
@digitallysavvy
Copy link
Contributor

v2.0.7 resolves this issue

@geotraveler
Copy link
Author

Yay! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants