Skip to content
This repository has been archived by the owner on Dec 5, 2019. It is now read-only.

Reenable bin/vat #50

Merged
merged 1 commit into from
May 21, 2019
Merged

Reenable bin/vat #50

merged 1 commit into from
May 21, 2019

Conversation

michaelfig
Copy link
Member

@michaelfig michaelfig commented May 21, 2019

Fixes #51

Add missing src/devices/index.js with named exports from the devices' top-halves.

@michaelfig
Copy link
Member Author

@warner

@michaelfig michaelfig requested a review from warner May 21, 2019 01:55
@warner
Copy link
Member

warner commented May 21, 2019

Could you run npm run-script lint-fix and appease eslint? It looks like the .js suffix needs to be removed from the new import pathnames. (normally CI should have noticed this, but for some reason it isn't running on PRs from repo forks)

Copy link
Member

@warner warner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, feel free to land after kate lands #48 (either do a merge commit or rebase to the subsequent trunk, either is good)

@warner
Copy link
Member

warner commented May 21, 2019

oh and maybe if you do a merge commit, include "fixes #51" in the commit comments so it'll close the bug

Add missing src/devices/index.js with named exports from the devices'
top-halves.

fixes #51
@michaelfig michaelfig merged commit ab04de8 into Agoric:master May 21, 2019
@michaelfig michaelfig deleted the src-devices-index branch May 21, 2019 16:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bin/vat doesn't work
2 participants