-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hardcode mnemonics #133
Hardcode mnemonics #133
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good.
Couple concerns:
- we shouldn't add any files to
.agoric
in the image. That's for validator state. We should actually be removing any files there that aren't in a production chain (optional to do in this PR) - there shouldn't be any new files in the repo root. The keys are a concern of
synthetic-chain
, not the repo.
We could put the files somewhere else, but I think it would be best not to make these into files. Just set put them as vars in env_setup.sh.
1d43bc8
to
b2fe5b7
Compare
Well, turns out we do have places that depends on, for example,
Maybe we can add them back into the container, but not under |
They're hard-coded now so we could copy the keys. Or put them somewhere else as you suggest, if we want to make it easy for downstream to look them up by name. I'd suggest a place like the upgrade-test-scripts path so that it's more clear they're not part of production |
Closes: #5
Testing
Not sure if I should add some tests that assert the addresses are expected, and if so, where should I add the tests?