Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: retry test failing for getting started integration tests #9740

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

frazarshad
Copy link
Contributor

@frazarshad frazarshad commented Jul 19, 2024

closes: #9325

Description

This PR fixes the issue with the integration (link-cli/yarn) job where on a retry of the step (due to the nick-fields/retry github action), the step fails because of a file already exists error.

The error occurs because we create an bin/agoric file in the previous run and on the retry it tries to recreate the file which already exists.

This is done by removing the bin/agoric file before the next retry occurs

Here is a test run for this PR where the job (link-cli/yarn) failed. The CI job repeats without any issues.
https://github.com/Agoric/agoric-sdk/actions/runs/10036266195/job/27733694026?pr=9740

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

Copy link

cloudflare-workers-and-pages bot commented Jul 19, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0b1bf64
Status: ✅  Deploy successful!
Preview URL: https://26b5ac86.agoric-sdk.pages.dev
Branch Preview URL: https://ci-retry-failure.agoric-sdk.pages.dev

View logs

@frazarshad frazarshad changed the title test ci: retry test failing for integration (link-cli/yarn) Jul 22, 2024
@frazarshad frazarshad marked this pull request as ready for review July 22, 2024 17:06
@frazarshad frazarshad requested a review from turadg July 22, 2024 17:07
Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase on master and remove the lines that redundantly delete the dir.

Also wrt the PR title, this is for the retry of all getting-started tests, not just link-cli.

@frazarshad frazarshad changed the title ci: retry test failing for integration (link-cli/yarn) ci: retry test failing for getting started integration tests Jul 22, 2024
@frazarshad frazarshad requested a review from turadg July 22, 2024 17:18
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.37%. Comparing base (ee2126b) to head (0b1bf64).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9740   +/-   ##
=======================================
  Coverage   56.36%   56.37%           
=======================================
  Files         667      667           
  Lines      207526   207526           
  Branches      339      339           
=======================================
+ Hits       116981   116993   +12     
+ Misses      90425    90416    -9     
+ Partials      120      117    -3     

see 2 files with indirect coverage changes

@frazarshad frazarshad added the automerge:rebase Automatically rebase updates, then merge label Jul 22, 2024
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@frazarshad frazarshad added automerge:rebase Automatically rebase updates, then merge and removed automerge:rebase Automatically rebase updates, then merge labels Jul 22, 2024
@mergify mergify bot merged commit 173e1d8 into master Jul 22, 2024
79 checks passed
@mergify mergify bot deleted the ci/retry-failure branch July 22, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flake: Getting Started (registry/yarn)
3 participants