-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: retry test failing for getting started integration tests #9740
Conversation
Deploying agoric-sdk with Cloudflare Pages
|
ac9823b
to
be429c1
Compare
c9ac27c
to
be429c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase on master and remove the lines that redundantly delete the dir.
Also wrt the PR title, this is for the retry of all getting-started tests, not just link-cli.
be429c1
to
8980adc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9740 +/- ##
=======================================
Coverage 56.36% 56.37%
=======================================
Files 667 667
Lines 207526 207526
Branches 339 339
=======================================
+ Hits 116981 116993 +12
+ Misses 90425 90416 -9
+ Partials 120 117 -3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
8980adc
to
0b1bf64
Compare
closes: #9325
Description
This PR fixes the issue with the integration (link-cli/yarn) job where on a retry of the step (due to the
nick-fields/retry
github action), the step fails because of afile already exists
error.The error occurs because we create an
bin/agoric
file in the previous run and on the retry it tries to recreate the file which already exists.This is done by removing the
bin/agoric
file before the next retry occursHere is a test run for this PR where the job (link-cli/yarn) failed. The CI job repeats without any issues.
https://github.com/Agoric/agoric-sdk/actions/runs/10036266195/job/27733694026?pr=9740
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations