Getting started tweaks #70
Conversation
michaelfig
force-pushed
the
mfig-hack-getting-started
branch
from
bed5441
to
50da48a
Compare
yarn.lock
Outdated
There was a problem hiding this comment.
Oh no we have a bunch of @endo and @babel deps that got bumped up!
There was a problem hiding this comment.
Yeah, I'd prefer to rely on resolutions in addition to the yarn.lock.
README.md
Outdated
| cd $HOME | ||
| # Install the dapp into a directory named demo | ||
| npm create @agoric/dapp@getting-started-dev init --dapp-template dapp-card-store --dapp-branch mhofman/hack-getting-started demo | ||
| npm create @agoric/dapp -- --dapp-template dapp-card-store --dapp-branch mhofman/hack-getting-started demo |
There was a problem hiding this comment.
Why remove the @getting-started-dev tag? until we publish a new latest, don't we need it?
There was a problem hiding this comment.
I published @agoric/create-dapp already since it uses the agoric@getting-started already, and only relies on agoric init to do the right thing, which it does.
There was a problem hiding this comment.
The latest tag is technically older: https://www.npmjs.com/package/@agoric/create-dapp?activeTab=versions
If we end up making changes, they wouldn't be picked up
|
FYI @dckc some dapp work for NPM compatibility that Michael and I did during the hackathon |
No description provided.