Add support for preserving ownership and timestamps from files #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ahuge
force-pushed
the
ah/feature/preserve-flags
branch
from
82036ce
to
9056373
Compare
The `--preserve-timestamp` flag will set metadata on the s3 objects and then update the files on disk during a download. If the `--preserve-timestamp` flag is passed during an upload the following metadata keys will be set: - x-amz-meta-file-ctime - x-amz-meta-file-mtime - x-amz-meta-file-atime If the `--preserve-timesamp` flag is passed during a download, s5cmd will attempt to modify the created files on disk. **There doesn't appear to be a way to change the created date on Linux ** Note this has been rebased as of 2024/03/06
Ahuge
force-pushed
the
ah/feature/preserve-flags
branch
from
9056373
to
3c8713d
Compare
|
!Blocked until Dan's testing is completed. |
The `--preserve-ownership` flag will query the user and group and store that in S3 as metadata. On Windows this stores the SID, on linux this stores the uid/gid. ** Note this has been rebased as of 2024/03/06
We encountered an issue in testing where the new owner of the file had no permissions of any of the downloaded files. It appears that this was due to the s5cmd process running as a SYSTEM service and executing --preserve-ownership to set the owner to "Ahuge".
These are zero length S3 objects with a name ending in a slash. We record the metadata about ownership, timestamps about these folders
Ahuge
force-pushed
the
ah/feature/preserve-flags
branch
from
3c8713d
to
571b158
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.