Fix a potential issue with race condition when reloading a config #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rikonen
reviewed
Apr 10, 2024
When SIGHUP is sent during `load_config` it's possible that `config_reload_pending` will be set to `False` (thus overwriting the `True` value, which was set in signal handler) and new reload won't happen.
alexole
force-pushed
the
alex-fix-race-condition-while-config-reload
branch
from
5a7066e
to
704841d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #122 +/- ##
==========================================
- Coverage 68.91% 68.64% -0.28%
==========================================
Files 10 10
Lines 1007 1011 +4
Branches 176 175 -1
==========================================
Hits 694 694
- Misses 257 261 +4
Partials 56 56 ☔ View full report in Codecov by Sentry. |
rdunklau
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When SIGHUP is sent during
load_configit's possible thatconfig_reload_pendingwill be set toFalse(thus overwriting theTruevalue, which was set in signal handler) and new reload won't happen.