[1] Add full support for Immersionkit options #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added minimal and maximal length for sentences
Merged
cd-FileX
changed the title
Avoiding an update of this once immersionkit might be updated
cd-FileX
pushed a commit
to cd-FileX/cropro
that referenced
this pull request
May 16, 2024
author Ren Tatsumoto <tatsu@autistici.org> 1713482484 +0000 committer FileX <filex.stuff@proton.me> 1715836203 +0900 Squash and rebase on top of main [1] Add full support for Immersionkit options (Ajatt-Tools#9) * Add more options to web filters * Add full immersion kit option compatibility Added minimal and maximal length for sentences * Revert layout renaming * Remove unused functions * Add min & max length only if needed * Set min & max length maximum higher Avoiding an update of this once immersionkit might be updated * apply proposed changes * restore position * format code * increase max limits * restore margins settings --------- Co-authored-by: FileX <filex.stuff@proton.me> Co-authored-by: Ren Tatsumoto <tatsu@autistici.org> move search bar position up move type Add more options to web filters format code remove unused methods change if logic add missing field restore original field names extract function rework tag previews update ajt common control field mapping in config add widgets for setting up remote field names rename sent to sentence Add presets to name settings Fit field names Rename fields to sentence Fix local search issue - map needed as list for indexing - setting the page buttons and page was not yet done Add page buttons to window reset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for wanikani and min/max length.
Wanikani in filter row, min max length in settings/web search.
Also moved the filter bar below the search bar to fit standard search layout.