Generate correct path key for typed path parameters #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ajaxy
requested changes
Dec 26, 2018
| @@ -271,7 +271,7 @@ function buildBodyParam(bodyParamsStr) { | |||
| } | |||
|
|
|||
| function buildPathKey(pathStr, group) { | |||
| return `${pathStr.replace(/:(.*?)(\/|$)/g, '{$1}$2')}${group}`; | |||
| return `${pathStr.replace(/:([^:/]+)(?::[^/]+)?(\/|$)/g, '{$1}$2')}${group}`; | |||
There was a problem hiding this comment.
How about this lazy RegExp: /:(.+?)(?::.+?)?(\/|$)/g?
.+? is a bit more general than [^:/] and [^/].
There was a problem hiding this comment.
This should work as well. (Although the amount of laziness here worries me.)
There was a problem hiding this comment.
Maybe it's just me, but when examining an RE with more than one non-greedy qualifier, I need to consider more variants to ensure it will not go the wrong way. With [^:/] and [^/], it's more straightforward and easier to understand.
The type and the preceding semicolon are now stripped from the path key.
pvgoran
force-pushed
the
typed-patch-params
branch
from
f8831a8
to
6c0f403
Compare
Ajaxy
approved these changes
Jan 17, 2019
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Path parameters can be typed (
/some/:param:integer); they are parsed and the parameter type is taken into account, but the resulting path key in the output contains the entire parameter specification (name:type) which is obviously incorrect.This PR modifies the code to strip the type and the preceding semicolon from the path key.