Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve highscore layout #19

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Improve highscore layout #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions bot/highscore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,26 @@

BUTTON_TEXTS = {
OVERALL_SCORE: 'Gesamter Highscore',
TODAYS_SCORE: 'Highscore von heute',
WEEKS_SCORE: 'Highscore der aktuellen Woche',
MONTHS_SCORE: 'Highscore des aktuellen Monats',
YEARS_SCORE: 'Highscore des aktuellen Jahres',
TODAYS_SCORE: 'Heute',
WEEKS_SCORE: 'Woche',
MONTHS_SCORE: 'Monats',
YEARS_SCORE: 'Jahr',
}
"""Dict[str, str]: Mapping giving for each callback data a corresponding text for the keyboard.
"""

HIGHSCORE_KEYBOARD = InlineKeyboardMarkup.from_column(
[InlineKeyboardButton(t, callback_data=d) for d, t in BUTTON_TEXTS.items()])
# yapf: disable
HIGHSCORE_KEYBOARD = InlineKeyboardMarkup([
[InlineKeyboardButton(BUTTON_TEXTS[OVERALL_SCORE], callback_data=OVERALL_SCORE)],
[
InlineKeyboardButton(BUTTON_TEXTS[TODAYS_SCORE], callback_data=TODAYS_SCORE),
InlineKeyboardButton(BUTTON_TEXTS[WEEKS_SCORE], callback_data=WEEKS_SCORE)
],
[
InlineKeyboardButton(BUTTON_TEXTS[MONTHS_SCORE], callback_data=MONTHS_SCORE),
InlineKeyboardButton(BUTTON_TEXTS[YEARS_SCORE], callback_data=YEARS_SCORE)
]])
# yapf: enable
"""
:class:`telegram.InlineKeyboardMarkup`: Keyboard to switch between the different highscores.
"""
Expand All @@ -54,7 +64,7 @@ def build_text(orchestra: Orchestra, interval: str) -> str:
interval: The requested interval.
"""
method = getattr(orchestra, "{}_score_text".format(interval))
return f'<b>{HEADINGS["{} highscore".format(interval)]}</b>\n\n{method(length=25, html=True)}'
return f'<b>{HEADINGS["{} highscore".format(interval)]}</b>\n\n{method(length=10, html=True)}'


def show_highscore(update: Update, context: CallbackContext) -> None:
Expand Down