Preventing some errors and showing all leases without search

[mhoffmann75]

split would have caused errors on malformed dhcp data.
dhcp leases should be shown without searching.

[Akkadius]

While when I wrote this the parser should always have a mac address going into this that is valid, but it doesn't hurt to validate before accessing.

I would check if mac is undefined and contains a : before doing the split again

[mhoffmann75]

Thanks for you answer.
Yes, you're absolutely right in theory EVERY entry in the dhcp servers table should have a mac address (Doesnt make sense to have a lease with no mac at all). Guess how surprised i was that in our network suddenly a lease (IP) occured with no mac addrsss. Making glass failing with error "split on undefined". Don't know how this actually occured or if its a bug in isc dhcp. But i needed to solve this.
Thats why i made this patch.

[dsgagi]

This could happen if DHCP server is not located in the same subnet as the client (like when using dhcp helper/relay), and lease gets abandoned. Here is an example below.

lease 192.168.134.94 {
  starts 5 2019/08/30 10:26:33;
  ends 6 2019/08/31 10:26:33;
  tstp 6 2019/08/31 10:26:33;
  cltt 5 2019/08/30 10:26:33;
  binding state abandoned;
  next binding state free;
  rewind binding state free;
  client-hostname "HUAWEI_Mate_20_Pro-de3aae";
}

[atownsend247]

I've also come across this when setting up isc-dhcp-server with a failover pair as it adds backup leases in like the below as an example.

lease 10.0.0.127 {
  starts 3 2019/10/30 13:30:37;
  tstp 3 2019/10/30 13:30:37;
  tsfp 3 2019/10/30 13:30:37;
  atsfp 3 2019/10/30 13:30:37;
  binding state backup;
}