Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Integrate with dagger 2 #21

Closed
wants to merge 1 commit into from
Closed

feat: Integrate with dagger 2 #21

wants to merge 1 commit into from

Conversation

Ezike
Copy link
Contributor

@Ezike Ezike commented Apr 17, 2019

resolves:#20

adds dagger integration to the project

@AkshayChordiya
Copy link
Owner

I tested the PR and it wasn't building due to few issues with ViewModel and Kotlin version [v1.3.30] hence I'm closing this PR and created another PR based upon this #22

@Ezike
Copy link
Contributor Author

Ezike commented Apr 20, 2019

Okay. I've been trying to resolve the problem with injecting the viewmodel into the viewmodelprovider.factory class

Like you said, seems to be an issue with version

@AkshayChordiya
Copy link
Owner

AkshayChordiya commented Apr 20, 2019

Yeah it was 2 fold problem.

  1. Needed to add few more things for `ViewModel
  2. Conflict with Dagger and Kotlin v1.3.30 (Class keys into map don't work in Kotlin 1.3.30 google/dagger#1478)

@Ezike
Copy link
Contributor Author

Ezike commented Apr 20, 2019

Okay. I saw that the issue was raised on the Dagger repo

@Ezike
Copy link
Contributor Author

Ezike commented Apr 20, 2019

I saw your invite to collaborate on the repo but the link seems broken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate with Dagger 2
2 participants