Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Sparks of the Future blocks to the grid analyzer. #37

Merged
merged 1 commit into from
Aug 21, 2020

Conversation

mleise
Copy link
Contributor

@mleise mleise commented Aug 16, 2020

That one line with the removes trailing space was my editor doing it's thing.

@mleise
Copy link
Contributor Author

mleise commented Aug 16, 2020

Oh wait, I edited the generated file in lib for the version, not the source. ;)

@mleise mleise force-pushed the master branch 2 times, most recently from e50f8a2 to b85614e Compare August 16, 2020 15:24
@Akuukis
Copy link
Owner

Akuukis commented Aug 16, 2020

Looks good, I will give it a test-run on the server and then merge.

Copy link
Owner

@Akuukis Akuukis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it out and run into problems. First need to bump steam version to trigger re-crawl, which works fine. Second need to add Symbols too, but it even after doing so it somehow didn't take it into account in praising.

Please update the PR and I will test again

workspaces/app/src/containers/App/index.tsx Show resolved Hide resolved
workspaces/app/src/containers/App/index.tsx Show resolved Hide resolved
workspaces/common/src/IBlueprint.ts Outdated Show resolved Hide resolved
workspaces/praisal/spec/addCubes.spec.ts Show resolved Hide resolved
workspaces/praisal/src/NewPraisalManager.ts Show resolved Hide resolved
@mleise mleise force-pushed the master branch 2 times, most recently from 7648212 to 6f1a3d3 Compare August 19, 2020 13:35
@sonarcloud
Copy link

sonarcloud bot commented Aug 19, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mleise
Copy link
Contributor Author

mleise commented Aug 19, 2020

Ok, Cubeblocks_Symbols.sbc is in now.

@Akuukis
Copy link
Owner

Akuukis commented Aug 19, 2020

@Akuukis Akuukis merged commit fc1e245 into Akuukis:master Aug 21, 2020
@Akuukis
Copy link
Owner

Akuukis commented Aug 21, 2020

@mleise all good, thank you! While testing I noticed another problem #38

@mleise
Copy link
Contributor Author

mleise commented Aug 21, 2020

Thumps up! Did you figure out what the problem was when you first ran the test? Was that just stale cached data?

@Akuukis
Copy link
Owner

Akuukis commented Aug 21, 2020

Nope, I guess just a random human error. Also, for next days we will have this problem #7

@Akuukis Akuukis mentioned this pull request Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants