Fix: AST to string causes double aliases #1459
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1426
During
ast.toString()
, the function alias is being set in two places: At theyy.FuncValue
level and theyy.Select
level. This is causing double aliases to be generated for functions when stringifying the AST, e.g.SELECT LENGTH(col) AS length AS length
.This problem would have existed on other tokens such as
yy.Literal
s too, but they seem to use an outdated(?)this.alias
which always returnsundefined
. Updating theyy.Literal
code to usethis.as
causes the problem to appear for literals too, e.g.SELECT col AS c AS c
.My solution is to just remove any alias handling-code from tokens which could represent columns, and let
yy.Select
handle those aliases as it currently does.