XLSX configure to read cell dates as js date obj #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test 3 is failing for me locally
but unlink is and also removes a file
just to make sure it works across years
barakplasma
changed the title
|
@mathiasrw @SamanthaAdrichem anything I need to do to move this PR along? It's passing GH Actions on my fork https://github.com/barakplasma/alasql/actions/runs/2609997786 |
|
I'm not a repository owner, nothing I can do about it :( I would how-ever verify (if I was you) what happens if XLSXopts is undefined / not set. |
|
@mathiasrw anything I can do to help get this moving? |
|
BTW, I'm running this patch in our prod using patch-package and it's working nicely. |
|
Thank you! |
mathiasrw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows users to configure XLSX library to convert cell dates to JS dates
Relates/resolves this issue comment: #395 (comment)
There's a list of options here: https://www.npmjs.com/package/xlsx#parsing-options