Skip to content
This repository has been archived by the owner on Dec 30, 2020. It is now read-only.

Wrong song picture loaded #5

Closed
xhuytox opened this issue Aug 21, 2019 · 3 comments
Closed

Wrong song picture loaded #5

xhuytox opened this issue Aug 21, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@xhuytox
Copy link

xhuytox commented Aug 21, 2019

This isn't big deal; only aesthetic. To reproduce, just type into the search really quickly. Preferably, type in a word that are in a lot of song names. While it tries to live-filter while the typing is happening, sometimes the wrong song pictures get associated to the final results.

@Alaanor
Copy link
Owner

Alaanor commented Aug 21, 2019

Yeah, I noticed this bug already, you're right, this happens when we type fast. I'm pretty sure it's because of the order of the async event. At each letter, it does the filter and asks for a new image. And sometime the previous search was slower than the new one, resulting in getting the wrong image.

It is on my task list. Thanks for the report.

@Alaanor Alaanor added the bug Something isn't working label Aug 21, 2019
@DanP27
Copy link

DanP27 commented Oct 2, 2019

I am also experiencing this bug - is there a fix planned?

@Alaanor
Copy link
Owner

Alaanor commented Oct 2, 2019

@DanP27 Yes, as you can see the commit referenced above (68e7987) is fixing the issue, however, it's planned for the next major release. (v1.1, which I'm working on it since months on my free time 👌 )
You can see the work done (and try it if you know the tools) on the feature-beatsaver-integration branch.

@Alaanor Alaanor closed this as completed in 68e7987 Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants