Fix tests #128
Merged
Fix tests #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, this PR fixes almost everything, only 4 tests left! DRProductionPrimitiveCompilationTest |
Closed
guillep
commented
Mar 18, 2024
Comment on lines
+27
to
+28
| (cogit isKindOf: SimpleDruidTestRTLCompiler) ifTrue: [ ^ self skip ]. | ||
|
|
There was a problem hiding this comment.
I skipped several tests like this. The reason is that primitiveAt has spill slots, but the access to the arguments in the stack is not aware of it. The code reads like
"Allocate 3 spill slots in the stack"
self SubCq: 24 R: SPReg.
self genLoadArg0R: R1
=>
genLoadArg0R: destinationRegister
self MoveMw: 'Fixed offset that does not take the spill slots into account' r: SPReg R: destinationRegister.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do a pass on tests to make the CI greener