Logging & Metrics #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version of Atom adds the ability to log all network requests to the Console app as well as export all logs to a file.
To take advantage of this new feature, set `log` property on Atom instance to `.on`:
```swift
let atom: Atom = {
let atom = Atom()
atom.log = .on
return atom
}()
```
Current implementation uses `os_log`.
If you choose to use the Console app for monitoring outgoing requests, you can use the following categories and subsystems to filter results.
Categories: Network, Authentication.
Subsystems: Your App’s Bundle Identifier.
### Changelog
* Add and implement required `OSLog` options.
* Add and implement required additions to `Bool`, `URLRequest`, `URLResponse`, `URLSessionTask`, `URLSessionTaskMetrics`.
* Introduce and implement `Interceptor` type.
* Update implementation of the `Service` and `AuthenticationManager` to use new `Interceptor` for logging requests to the Console.
* Update the Example app.
* Update documentation.
Defilan
approved these changes
Mar 22, 2020
There was a problem hiding this comment.
Looks good @michaelbabiy . Sorry it took me so long to approve :)
|
Thanks @Defilan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version of Atom adds the ability to log all network requests to the Console app as well as export all logs to a file.
To take advantage of this new feature, set
logproperty on Atom instance to.on:Current implementation uses
os_log.If you choose to use the Console app for monitoring outgoing requests, you can use the following categories and subsystems to filter results.
Categories: Network, Authentication.
Subsystems: Your App’s Bundle Identifier.
Changelog
OSLogoptions.Bool,URLRequest,URLResponse,URLSessionTask,URLSessionTaskMetrics.Interceptortype.ServiceandAuthenticationManagerto use newInterceptorfor logging requests to the Console.