Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update color tokens for theming support #95

Closed
2 tasks
jordanjones243 opened this issue Mar 13, 2024 · 3 comments · Fixed by #102, #103, #105, #106 or #107
Closed
2 tasks

Update color tokens for theming support #95

jordanjones243 opened this issue Mar 13, 2024 · 3 comments · Fixed by #102, #103, #105, #106 or #107
Assignees

Comments

@jordanjones243
Copy link
Contributor

jordanjones243 commented Mar 13, 2024

General Support Request

In order to make Auro components themeable, we need to make sure there are no hard-coded and correct semanticly named tokens within the component. There also needs to be investigation around border rules which have a combination of size and color tokens, making them more complex, as well as background-color and color rules.

Possible Solution

Work with designers to figure out what tokens need updated values or renamed.

Additional context

This work stems from theming work happening to all Auro components:

Acceptance Criteria:

  • All tier 3 token names have been implemented.
  • Colors identified below have been updated to their tier 3 token name.
@jordanjones243
Copy link
Contributor Author

  • Tier 1:
    • Target box-shadow: inset 0 0 0 1px var(--ds-color-base-white, $ds-color-base-white), inset 0 0 0 3px var(--ds-color-background-lightest, $ds-color-background-lightest);
    • On dark background and border color: var(--ds-color-brand-breeze-300, $ds-color-brand-breeze-300);
    • Ondark not disabled Hover/active background and border: var(--ds-color-brand-breeze-200, $ds-color-brand-breeze-200);
    • Label border color: var(--ds-color-brand-neutral-500, $ds-color-brand-neutral-500);
    • Label error and success color: var(--ds-color-base-white, $ds-color-base-white);
  • Hardcoded
    • Transparent

@jordanjones243
Copy link
Contributor Author

This ticket will be blocked until this work has been completed:

@jordanjones243 jordanjones243 removed their assignment Jul 9, 2024
@jordanjones243 jordanjones243 linked a pull request Jul 24, 2024 that will close this issue
6 tasks
@jordanjones243 jordanjones243 self-assigned this Jul 24, 2024
@jason-capsule42 jason-capsule42 linked a pull request Jul 26, 2024 that will close this issue
6 tasks
blackfalcon pushed a commit that referenced this issue Jul 27, 2024
# [2.6.0-beta.1](v2.5.0...v2.6.0-beta.1) (2024-07-27)

### Features

* implement color theming support [#95](#95) ([be19d95](be19d95))

### Performance Improvements

* add component attribute when custom named ([3ef578e](3ef578e))
* correct the script for husky ([63c0b29](63c0b29))
@jason-capsule42 jason-capsule42 linked a pull request Jul 27, 2024 that will close this issue
6 tasks
@jason-capsule42 jason-capsule42 linked a pull request Jul 27, 2024 that will close this issue
6 tasks
@jason-capsule42 jason-capsule42 linked a pull request Jul 27, 2024 that will close this issue
6 tasks
blackfalcon pushed a commit that referenced this issue Jul 27, 2024
# [2.6.0-beta.1](v2.5.0...v2.6.0-beta.1) (2024-07-27)

### Features

* implement color theming support [#95](#95) ([9c52813](9c52813))
* support custom element naming with attribute ([6ee92d6](6ee92d6))

### Performance Improvements

* correct the script for husky ([3620ef4](3620ef4))
@jason-capsule42 jason-capsule42 linked a pull request Jul 27, 2024 that will close this issue
6 tasks
blackfalcon pushed a commit that referenced this issue Jul 27, 2024
# [2.6.0-beta.1](v2.5.0...v2.6.0-beta.1) (2024-07-27)

### Features

* implement color theming support [#95](#95) ([d8fc452](d8fc452))
blackfalcon pushed a commit that referenced this issue Jul 28, 2024
# [2.6.0-beta.1](v2.5.1-beta.1...v2.6.0-beta.1) (2024-07-28)

### Features

* implement color theming support [#95](#95) ([473594c](473594c))
* testing release process ([6d41b1b](6d41b1b))
@jordanjones243 jordanjones243 linked a pull request Aug 14, 2024 that will close this issue
6 tasks
@jordanjones243
Copy link
Contributor Author

Blocked until the auro-button theming support issues are dealt with.

jordanjones243 added a commit that referenced this issue Sep 26, 2024
BREAKING CHANGE: trigger major release for color theme support #95
jordanjones243 added a commit that referenced this issue Sep 26, 2024
BREAKING CHANGE: trigger major release for color theme support #95
blackfalcon pushed a commit that referenced this issue Sep 26, 2024
# [3.0.0-beta.1](v2.6.0-beta.2...v3.0.0-beta.1) (2024-09-26)

### Performance Improvements

* refactor custom component registration config ([891f44a](891f44a))
* update dependencies ([363d86d](363d86d))

### BREAKING CHANGES

* trigger major release for color theme support #95
jason-capsule42 pushed a commit that referenced this issue Sep 30, 2024
BREAKING CHANGE: trigger major release for color theme support #95
jason-capsule42 pushed a commit that referenced this issue Sep 30, 2024
# [3.0.0-beta.1](v2.6.0-beta.2...v3.0.0-beta.1) (2024-09-26)

### Performance Improvements

* refactor custom component registration config ([891f44a](891f44a))
* update dependencies ([363d86d](363d86d))

### BREAKING CHANGES

* trigger major release for color theme support #95
blackfalcon pushed a commit that referenced this issue Sep 30, 2024
# [3.0.0](v2.5.0...v3.0.0) (2024-09-30)

### Bug Fixes

* update commitlint rules config ([560b7a2](560b7a2))

### Features

* add all code necessary for theme support ([c2cd6f4](c2cd6f4))
* force version bump and release ([921689a](921689a))

### Performance Improvements

* refactor custom component registration config ([70c1cb2](70c1cb2))
* update dependencies ([3df2530](3df2530))

### BREAKING CHANGES

* trigger major release for color theme support #95
@jason-capsule42 jason-capsule42 removed Type: Feature New Feature Type: Design New Design labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment