Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update color tokens for theming support #95

Open
2 tasks
jordanjones243 opened this issue Mar 13, 2024 · 1 comment
Open
2 tasks

Update color tokens for theming support #95

jordanjones243 opened this issue Mar 13, 2024 · 1 comment
Assignees
Labels

Comments

@jordanjones243
Copy link
Contributor

jordanjones243 commented Mar 13, 2024

General Support Request

In order to make Auro components themeable, we need to make sure there are no hard-coded and correct semanticly named tokens within the component. There also needs to be investigation around border rules which have a combination of size and color tokens, making them more complex, as well as background-color and color rules.

Possible Solution

Work with designers to figure out what tokens need updated values or renamed.

Additional context

This work stems from theming work happening to all Auro components:

Acceptance Criteria:

  • All tier 3 token names have been implemented.
  • Colors identified below have been updated to their tier 3 token name.
@jordanjones243
Copy link
Contributor Author

  • Tier 1:
    • Target box-shadow: inset 0 0 0 1px var(--ds-color-base-white, $ds-color-base-white), inset 0 0 0 3px var(--ds-color-background-lightest, $ds-color-background-lightest);
    • On dark background and border color: var(--ds-color-brand-breeze-300, $ds-color-brand-breeze-300);
    • Ondark not disabled Hover/active background and border: var(--ds-color-brand-breeze-200, $ds-color-brand-breeze-200);
    • Label border color: var(--ds-color-brand-neutral-500, $ds-color-brand-neutral-500);
    • Label error and success color: var(--ds-color-base-white, $ds-color-base-white);
  • Hardcoded
    • Transparent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants