Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flac lossless streaming #794

Merged
merged 11 commits into from
Feb 25, 2024
Merged

Conversation

Samt43
Copy link
Contributor

@Samt43 Samt43 commented Oct 12, 2023

What does this PR do and why is it necessary?

It permits to webstream with a lossless quality using the flac codec.

How was it tested? How can it be tested by the reviewer?

On my computer, to test it you can execute : welle_cli -O flac, then your available streamings will be encoded in flac

janblaesi and others added 8 commits June 20, 2022 11:22
Homebrew Formula: Update version and remove unused SoapySDR dependency
…nd the flac header at the beginning og the stream
…put encoding of the stream.

Flac is a lossless format and ensures the stream is perfectly equivalent to the one that have been broadcasted
@mpbraendli
Copy link
Collaborator

Hi, interesting proposal!

Question: If you configure flac output on the command line, but then fetch the backward-compatible mp3/ URL, do you get FLAC or MP3?

Would it be possible to replace the command line option, and return flac for /stream/ (or, more logically, /flac/) and return mp3 on the /mp3/ URLs?

If you don't want to do that, do not offer the /mp3 endpoint when flac is selected, that would be misleading.

Thanks!

@Samt43
Copy link
Contributor Author

Samt43 commented Oct 12, 2023

@mpbraendli : Yes, i missed that, thanks, just added another commit for allowing /mp3/ only when mp3 output is active

This PR is now fully tested, and working.
Stream endpoint remains as it permits to have transparency  on the codec used by backend.
@Samt43
Copy link
Contributor Author

Samt43 commented Oct 13, 2023

Fully tested and working ! Please note that the station switch is faster using flac :)

@mpbraendli mpbraendli self-assigned this Feb 19, 2024
@mpbraendli
Copy link
Collaborator

Hi, sorry we didn't look into your PR earlier. I believe this can be accepted. @AlbrechtL ok with that?

Copy link
Owner

@AlbrechtL AlbrechtL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you activites and improvements!

@AlbrechtL AlbrechtL merged commit 552ccae into AlbrechtL:next Feb 25, 2024
1 check passed
@Samt43
Copy link
Contributor Author

Samt43 commented Feb 29, 2024

Thanks you for this amazing project !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants