-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flac lossless streaming #794
Conversation
Homebrew Formula: Update version and remove unused SoapySDR dependency
Add a pull request template
…nd the flac header at the beginning og the stream
…put encoding of the stream. Flac is a lossless format and ensures the stream is perfectly equivalent to the one that have been broadcasted
Hi, interesting proposal! Question: If you configure Would it be possible to replace the command line option, and return flac for If you don't want to do that, do not offer the Thanks! |
@mpbraendli : Yes, i missed that, thanks, just added another commit for allowing /mp3/ only when mp3 output is active |
This PR is now fully tested, and working.
Stream endpoint remains as it permits to have transparency on the codec used by backend.
Fully tested and working ! Please note that the station switch is faster using flac :) |
Hi, sorry we didn't look into your PR earlier. I believe this can be accepted. @AlbrechtL ok with that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for you activites and improvements!
Thanks you for this amazing project ! |
What does this PR do and why is it necessary?
It permits to webstream with a lossless quality using the flac codec.
How was it tested? How can it be tested by the reviewer?
On my computer, to test it you can execute : welle_cli -O flac, then your available streamings will be encoded in flac