Switch ingredient update response from Javascript to Turob Stream #2891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to call functions that are registered as action from a `turbo_stream` response. It supports closeCurrentDialog, reloadPreview, and updateAnchorIcon. The closeCurrentDialog is an intermediate solution until all dialogs will respond with a promise.
As a preparation to replace the Rails Javascript responses, the ingredient update response was replaced with turbo stream. It now uses the alchemy-action - component to trigger action in our frontend. As an addition the response also triggers a previewReload action to reflect the changes in the settings of an ingredient.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2891 +/- ##
==========================================
+ Coverage 95.94% 95.95% +0.01%
==========================================
Files 230 230
Lines 6260 6258 -2
==========================================
- Hits 6006 6005 -1
+ Misses 254 253 -1 ☔ View full report in Codecov by Sentry. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
alchemy-action- component (which is an extend version of wip: Add alchemy-action #2883)Checklist