Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clippy lints #912

Merged
merged 1 commit into from
Jul 8, 2021
Merged

chore: clippy lints #912

merged 1 commit into from
Jul 8, 2021

Conversation

niklaslong
Copy link
Collaborator

Fixes a few needless borrow lints.

In addition some of the lints are caused by false positives: rust-lang/rust-clippy#7422, these should be fixed in the next nightly release.

@niklaslong niklaslong requested a review from ljedrz July 5, 2021 12:27
Copy link
Collaborator

@ljedrz ljedrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Humans will never beat clippy at this lint 🙂.

LGTM 👌

@codecov
Copy link

codecov bot commented Jul 5, 2021

Codecov Report

Merging #912 (a0f93ae) into staging (0152f3f) will increase coverage by 0.36%.
The diff coverage is 94.14%.

Impacted file tree graph

@@             Coverage Diff             @@
##           staging     #912      +/-   ##
===========================================
+ Coverage    83.14%   83.51%   +0.36%     
===========================================
  Files           39       36       -3     
  Lines          724      734      +10     
===========================================
+ Hits           602      613      +11     
+ Misses         122      121       -1     
Impacted Files Coverage Δ
consensus/src/error.rs 0.00% <ø> (ø)
metrics/src/lib.rs 100.00% <ø> (ø)
network/src/errors/network.rs 0.00% <ø> (ø)
network/src/lib.rs 100.00% <ø> (ø)
network/src/message/message.rs 14.28% <ø> (+3.75%) ⬆️
network/src/message/payload_capnp.rs 100.00% <ø> (ø)
network/src/message/version.rs 60.00% <0.00%> (+26.66%) ⬆️
rpc/src/lib.rs 100.00% <ø> (ø)
snarkos/main.rs 100.00% <ø> (ø)
storage/src/lib.rs 100.00% <ø> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae6d9cd...a0f93ae. Read the comment docs.

@niklaslong niklaslong added the refactor Codebase refactor, optimization, or cleanup label Jul 5, 2021
@ljedrz ljedrz merged commit b912f4c into AleoNet:staging Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Codebase refactor, optimization, or cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants