Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove storage and testing crates #140

Merged
merged 1 commit into from
Apr 1, 2021

Conversation

ljedrz
Copy link
Collaborator

@ljedrz ljedrz commented Apr 1, 2021

This PR removes the storage and testing crates (they reside in snarkOS now), making snarkVM free of the dependency on rocksdb and greatly speeding up its compilation time. The tests that depend on snarkos-testing and snarkos-storage reside in a new snarkos-integration crate, which is not a member of the snarkVM workspace.

In order to run the aforementioned tests, the CI needs to be adjusted so that snarkos-integration tests have their own dedicated run; the associated image should also contain the necessary parameters, otherwise they take a while to download.

note: since the snarkos crates need to be aligned with the current snarkVM APIs, the snarkOS repository linked in Cargo.toml within snarkos-integration currently points to a branch associated with https://github.com/AleoHQ/snarkOS/pull/677. This can be changed once that PR is merged (to a fresh AleoHQ/snarkOS commit) or to a released version once it's released.

Signed-off-by: ljedrz <ljedrz@gmail.com>
@ljedrz
Copy link
Collaborator Author

ljedrz commented Apr 1, 2021

another note: Cargo.lock in snarkos-integration might be unnecessary - it can be removed if desired.

@howardwu
Copy link
Contributor

howardwu commented Apr 1, 2021

note to self: TODO - change the snarkOS dependencies to the next release in snarkos-integration/Cargo.toml

@howardwu howardwu merged commit 0f11209 into AleoNet:master Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants