Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
storage
andtesting
crates (they reside in snarkOS now), making snarkVM free of the dependency onrocksdb
and greatly speeding up its compilation time. The tests that depend onsnarkos-testing
andsnarkos-storage
reside in a newsnarkos-integration
crate, which is not a member of the snarkVM workspace.In order to run the aforementioned tests, the CI needs to be adjusted so that
snarkos-integration
tests have their own dedicated run; the associated image should also contain the necessary parameters, otherwise they take a while to download.note: since the snarkos crates need to be aligned with the current snarkVM APIs, the snarkOS repository linked in
Cargo.toml
withinsnarkos-integration
currently points to a branch associated with https://github.com/AleoHQ/snarkOS/pull/677. This can be changed once that PR is merged (to a freshAleoHQ/snarkOS
commit) or to a released version once it's released.