Fix program fetching in cost function #1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for doing this @HarukaMa ! I was planning to do it myself as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In
snarkos developercontext, we don't really have a transaction storage; programs are added toProcessdirectly. This will cause executing to fail as thecostfunction can't find the program in the non-existent storage. This PR makes thecostfunction read the program directly from theProcessinstead of the consensus storage to make executing work again.Test Plan
Well, there really should be a test case for this but I didn't write one...
Related PRs
(What's that
protocol-docsrepo? Seems it's private.)