Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement casting for ProgramPrivateVariables trait #343

Merged
merged 1 commit into from
Aug 5, 2021
Merged

Implement casting for ProgramPrivateVariables trait #343

merged 1 commit into from
Aug 5, 2021

Conversation

raychu86
Copy link
Contributor

@raychu86 raychu86 commented Aug 4, 2021

Motivation

This adds a required function as_any to the ProgramPrivateVariables trait, to facilitate casting casting the private: &dyn ProgramPrivateVariables<C> variable into usable structs without having to use unsafe transmutes.

@howardwu howardwu changed the base branch from groth16 to testnet2 August 5, 2021 03:47
@howardwu howardwu changed the base branch from testnet2 to groth16 August 5, 2021 03:47
@howardwu howardwu merged commit 155bb59 into groth16 Aug 5, 2021
@howardwu howardwu deleted the feat/witness-variable-casting branch August 5, 2021 03:48
howardwu pushed a commit that referenced this pull request Aug 5, 2021
Adds PR #343
9eb02bf
This was referenced Aug 5, 2021
Closed
Merged
howardwu pushed a commit that referenced this pull request Aug 5, 2021
Adds PR #343
84c37f5
@raychu86 raychu86 mentioned this pull request Sep 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardwu howardwu howardwu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raychu86 @howardwu