Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coerce passed type to TS before invoking ::name() #318

Merged
merged 2 commits into from
May 17, 2024
Merged

Coerce passed type to TS before invoking ::name() #318

merged 2 commits into from
May 17, 2024

Commits on May 17, 2024

  1. Coerce passed type to TS before invoking ::name() 

    If we're running the macro on a type which has an in-scope trait
containing a `::name` member, the compiler will not know which to
invoke.

This clarifies that in the macro's context, we want to invoke the
TS::name trait method by first casting the argument to the TS trait.

This pattern is in some other parts of the macro, I think this one was
just triggered previously.

Signed-off-by: Paul R. Tagliamonte <paultag@gmail.com>
    @paultag
    paultag committed May 17, 2024
    Configuration menu
    Copy the full SHA
    7b987a6 View commit details
    Browse the repository at this point in the history

  2. further qualify other uses of TS in macros

    @NyxCode
    NyxCode committed May 17, 2024
    Configuration menu
    Copy the full SHA
    187ae83 View commit details
    Browse the repository at this point in the history