Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed websocket connection console errors #1004

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Fixed websocket connection console errors #1004

merged 1 commit into from
Sep 15, 2023

Conversation

pepermao
Copy link
Collaborator

  • only create websocket connection when colllab edit feature flag is enabled

@sonarcloud
Copy link

sonarcloud bot commented Sep 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@thesocialdev thesocialdev merged commit 5641127 into stage Sep 15, 2023
4 checks passed
@thesocialdev thesocialdev deleted the fixed-creation-of-websocket-connection branch September 15, 2023 14:56
@thesocialdev thesocialdev mentioned this pull request Sep 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesocialdev thesocialdev thesocialdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pepermao @thesocialdev