-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autogear wont work on druid #45
Comments
@AlexFolland |
I am also having this issue. Works on my paladin, not on my druid though. |
Thanks for the report. What edition of the game is this, and what is the output of |
Hi,
Thanks for getting back! I am playing on WOTLK Classic, here is the output
you requested:
[image: image.png]
Whihc is odd, because in both AG and Pawn I have Feral (Damage) chosen.
…On Thu, Jun 29, 2023 at 2:01 PM Alex Folland ***@***.***> wrote:
Thanks for the report. What edition of the game is this, and what is the
output of /ag spec in the chat?
—
Reply to this email directly, view it on GitHub
<#45 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BA5JHNXYG25YE3ACQJSTIB3XNXGKLANCNFSM6AAAAAAWQQB2YU>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Your image attachment didn't work. It looks like it was lost in translation from your email response to the github issue ticket comment. Can you please try navigating fully to this issue ticket on the github website, then pasting the image from your clipboard while the github comment editor is focused in your web browser? Alternatively, transcribing the chat output to text here would work. |
This looks only like your configuration is not working the way you expect it to work, which would just need support and not necessarily a bug fix. However, if there are Lua errors also being thrown, there is a real bug to fix. Do you see Lua errors as well? If so, can you please paste the exact error output from BugSack, or confirm it's the same as posted earlier in this issue ticket, plus what the error count you see is? |
I am getting the same exact error as above. I'm new to BugSack but will paste what I get below. Before installing bugsack the counter would just run up infinite until I disabled and /reload. I would usually get a warning in the low 1000's to disable all addons but it was only AG causing the issue.
Like I said above, no issues with my paladin, the lua errors only show on my druid. |
Thanks. That helps a lot. The output you've pasted includes the local variable values, which the screenshot earlier did not include. The only way I can see this error happening is if Therefore, I'd like to ask you to try to run |
Here is the output:
|
OK, so it's not |
I have another thought. I wonder if it doesn't throw an error if Pawn is disabled. This is obviously not what we want, but if that's the case, then it'll give me more information about how to track this down. |
OK, thanks. When, exactly, is the error thrown? Is it only when you enter the game world, or is it some time after? If after, what action(s) trigger(s) it? |
It seems to be when items are looted, or I try equipping an item. For instance, I've been playing for about 10 min with just AG turned on, no error yet but I haven't looted gear from any mobs. I just tried changing my cloak and this error triggered:
|
The above triggers when I try to equip a different peice of gear, but does not go infinite, the below triggers when looting gear and does go infinite
|
Thank you for the analysis! Are there more locals in those error messages, like you included before? Seeing the local variable values is extremely useful for figuring this out. |
I'm not sure what you mean by locals? Would it show in the same place near the bottom of the error? If so, no. I copy/pasted the whole lua error. Let me know if I should be looking elsewhere. Oooh wait do you mean like the bugsack report I uploaded earlier? I can turn bugsack back on and try to get the error to trigger again if that's what you need. |
Here is the bug when trying to equip an item from bags |
The "locals" are the local variables and their values at the execution point which triggered the error. It's important to see that |
Can you show me what you have set in AutoGear's settings? This can be with your usual addons enabled. I just want to see override settings. Also, would you mind telling me what happens if you equip a different piece of gear after disabling an override? Also, what language is the game set to? If not English, can you tell me what happens if you try setting the game language to English, restarting, and trying equipping a different piece of gear? |
Game is in English, I'm playing in the US and can only speak English :) Also, would you mind telling me what happens if you equip a different piece of gear after disabling an override? What do you mean by override? Do you mean if I equip, cause the error, close it out, and try again? Because I can't get the error window to close it keeps repopulating once it starts. |
I agree this is confusing, I don't understand why it would even need AutoGearDefaultWeight info pulled if it's using Pawn's? |
Explanation of that: The weapons preferred by each spec are still used from AutoGear doesn't actually know Pawn's stat weights at all. It only uses Pawn's stat weights when evaluating the score for an item in The issue is still cursed, as accessing |
Ah okay, thanks for the explanation! I'm definitely no coder but I do like to understand the logic. And sounds good on the 2nd opinion, I will just play without it for now. |
I've released an alpha version of the addon which may work around the issue, even though it doesn't resolve it properly since the issue still makes no sense. If it does work around the issue, please let me know. If you find any regressions the attempted fix caused, please let me know. I'm doing this blindly without testing. |
I've tagged it for release, so now there are release packages. Please let me know if the workaround helps. |
Sadly same/similar error on my druid. Still stable on my paladin:
|
Oh, looks like you are still running the previous version. I see why, too. There's a BigWigs packager bug which I reported here causing the release package to have been uploaded as alpha. For now, please try the alpha package, which is the current version. |
Well, slightly different infinite error now. This didn't trigger right away either it took like 30 mins to start going off.
|
To reach line 3760, you have to have the Pawn option disabled or Pawn itself disabled. Did either Pawn or the AutoGear option for Pawn get disabled? Also, was AutoGear working until then? |
I added a check at that line which should at least try to set stat weights again if they're missing there. That being said, I'm still interested in the answers to my questions in my previous comment. |
Hmmm, my last play session of several hours just now I never got an error to trip. I did check and with the reinstall I forgot to tell AutoGear to use Pawns stat weights so it was going off the internal weighting. Next time I play I can see if the Pawn weighting works as well or if that triggers anything. |
I've made many changes which include more than 1 major refactor, which may have caused this to be fixed. Can you still reproduce this issue? |
Hi
Today i used ag on my druid but it keeps giving me this error and ag wont work
The text was updated successfully, but these errors were encountered: