This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Path concatenation fix (didn't support cross platform directory paths) #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if plural separator does not exist in value return name AlexTeixeira#38
…ry cache key that is used when storing data to cache.
|
Hi, Thank you for contributing to this project :) As I can see, you fixed two things in this pull request ? Could you just try to fix the two tests that are not working in appveyor ? One of both fails : Thanks |
This was referenced May 1, 2019
Merged
|
Merge in #51 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed hardcoded "/" and used cross platform path combining...