-
-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sway/workspaces displays __i3_scratch as a workspace if all-outputs is true #2966
Comments
Unfortunately that was noty intended behaviour, i never use the scratch
workspace.
I'm unsure what would be the best behaviour here, my gut feeling is to
filter out this special workspace, is it normally visible when its in use
or not even then?
…On Sat, 24 Feb 2024, 16:36 René D. Obermüller, ***@***.***> wrote:
This seems to be a consequence of bb843e0
<bb843e0>
/ PR #2944 <#2944>. Specifically,
the commit replaced get_workspaces with get_tree. get_tree includes
__i3_scratch as a workspace object on the output "__i3", while
get_workspaces does not.
satty-20240224-15.05.11.png (view on web)
<https://github.com/Alexays/Waybar/assets/29629287/23f8eb33-6442-42ce-9946-daceac6da816>
The upper waybar includes the commit, the bottom does not.
@grimpy <https://github.com/grimpy>
Is this intended? I suppose it could be useful, even more so if I could
specifically rename it or display a counter. Clicking it creates a new
workspace "__i3_scratch" beneath the active output, not the invisible
"__i3" output. That is a bit weird. While this is something that can be
done through IPC without waybar altogether, and there's nothing we can do
about it, I do feel if this were to be a feature in the module, it should
get some special handling. The identification for this could be "workspace
__i3_scratch on output __i3".
—
Reply to this email directly, view it on GitHub
<#2966>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABDD7M3ZZCUAW6E3JIKTZDYVH3HXAVCNFSM6AAAAABDYBZ6LWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGE2TEMZUGI2TONY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Thanks for the reply. The scratchpad is just a place to store windows in, but it is never directly visible. So far, sway/workspaces has not displayed it. That's not to say it couldn't be useful at all, but as mentioned above, not really without special handling. I think your intuition is correct here. We should filter it for now. If somebody feels like including it in a more sophisticated fashion, that's always possible as a new feature down the road. I believe that might be better suited for a separate scratchpad module, though. EDIT: just noticed there IS a scratchpad module since Aug 2022, wonder how I managed to miss that one all the time. |
Fixes: Alexays#2966 Signed-off-by: Jo De Boeck <deboeck.jo@gmail.com>
This seems to be a consequence of bb843e0 / PR #2944. Specifically, the commit replaced
get_workspaces
withget_tree
.get_tree
includes __i3_scratch as a workspace object on the output "__i3", whileget_workspaces
does not.The upper waybar includes the commit, the bottom does not.
@grimpy
Is this intended? I suppose it could be useful, even more so if I could specifically rename it or display a counter. Clicking it creates a new workspace "__i3_scratch" beneath the active output, not the invisible "__i3" output. That is a bit weird. While this is something that can be done through IPC without waybar altogether, and there's nothing we can do about it, I do feel if this were to be a feature in the module, it should get some special handling. The identification for this could be "workspace __i3_scratch on output __i3".
The text was updated successfully, but these errors were encountered: