Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sway/workspaces displays __i3_scratch as a workspace if all-outputs is true #2966

Closed
RobertMueller2 opened this issue Feb 24, 2024 · 2 comments · Fixed by #2979
Closed

sway/workspaces displays __i3_scratch as a workspace if all-outputs is true #2966

RobertMueller2 opened this issue Feb 24, 2024 · 2 comments · Fixed by #2979
Labels
custom enhancement New feature or request sway

Comments

@RobertMueller2
Copy link
Contributor

This seems to be a consequence of bb843e0 / PR #2944. Specifically, the commit replaced get_workspaces with get_tree. get_tree includes __i3_scratch as a workspace object on the output "__i3", while get_workspaces does not.

satty-20240224-15:05:11

The upper waybar includes the commit, the bottom does not.

@grimpy
Is this intended? I suppose it could be useful, even more so if I could specifically rename it or display a counter. Clicking it creates a new workspace "__i3_scratch" beneath the active output, not the invisible "__i3" output. That is a bit weird. While this is something that can be done through IPC without waybar altogether, and there's nothing we can do about it, I do feel if this were to be a feature in the module, it should get some special handling. The identification for this could be "workspace __i3_scratch on output __i3".

@github-actions github-actions bot added custom enhancement New feature or request sway labels Feb 24, 2024
@grimpy
Copy link
Contributor

grimpy commented Feb 24, 2024 via email

@RobertMueller2
Copy link
Contributor Author

RobertMueller2 commented Feb 24, 2024

Thanks for the reply. The scratchpad is just a place to store windows in, but it is never directly visible.

So far, sway/workspaces has not displayed it. That's not to say it couldn't be useful at all, but as mentioned above, not really without special handling. I think your intuition is correct here. We should filter it for now.

If somebody feels like including it in a more sophisticated fashion, that's always possible as a new feature down the road. I believe that might be better suited for a separate scratchpad module, though. (In fact I got that one on my list for trying out a Rust cffi waybar module, but who knows if I can pull that off within the next 3 or 4 years. 😛 )

EDIT: just noticed there IS a scratchpad module since Aug 2022, wonder how I managed to miss that one all the time.

grimpy added a commit to grimpy/Waybar that referenced this issue Feb 27, 2024
Fixes: Alexays#2966

Signed-off-by: Jo De Boeck <deboeck.jo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
custom enhancement New feature or request sway
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants