-
-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
c++20. clock chrono API. STL + format #2659
Conversation
Signed-off-by: Viktar Lukashonak <myxabeer@gmail.com>
Even clang CI has failed (due to timeout reason) in my branch it looks OK |
We got a failure in nixpkgs-wayland
|
I'll check soon |
Commit 86a3898 broke the parsing of Not a big deal, but it would be nice to mention breaking changes somewhere in the changelog. I have updated the wiki page about the clock. cc: @Alexays |
Hi @Alexays ,
This PR is created in order to fully switch clock module to use standard chrono library + format library in c++20. date library by @HowardHinnant has been taken into standard in C++20. STL format library supports chrono now.
So clock module under C++20 now no more using fmt library and construct necessary information using STL.
One more major change: clock module is fully rewritten and as a base is using TZ(zoned time). It should minimize time conversion between local and zoned time.
Structure of the helper include/util/date.hpp now provides compile time switching between
"date/tz.h" + "fmt/chrono.h" <-> <chrono> + <format>
timezoned_time_list placeholder now is renamed to tz_list . This change is attracted in man page too.
+ it should solve any issues during compilation when compiler gets ambiguous errors of the date/format functions
This PR is also a prerequisite to start digging into different calendar implementation (what is raised in #2260)