Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customization of battery module tooltip #830

Merged
merged 4 commits into from
Jan 18, 2021
Merged

Allow customization of battery module tooltip #830

merged 4 commits into from
Jan 18, 2021

Conversation

Markaos
Copy link
Contributor

@Markaos Markaos commented Aug 19, 2020

This commit allows users to change tooltip format using tooltip-format[-status][-state] parameters. It also adds autoTooltip (I couldn't come up with anything better) format argument containing the "default" tooltip text.

This shouldn't affect existing configs

Copy link
Owner

@Alexays Alexays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, here's a review :)

src/modules/battery.cpp Outdated Show resolved Hide resolved
@Markaos
Copy link
Contributor Author

Markaos commented Jan 18, 2021

I agree, timeTo sounds like a reasonable name

@Markaos Markaos requested a review from Alexays January 18, 2021 11:40
@Alexays
Copy link
Owner

Alexays commented Jan 18, 2021

Thanks!

@Alexays Alexays merged commit e06d603 into Alexays:master Jan 18, 2021
@Alexays
Copy link
Owner

Alexays commented Jan 18, 2021

Could you update github wiki? :)

@Markaos
Copy link
Contributor Author

Markaos commented Jan 18, 2021

Sure, I'm on it

@Markaos Markaos deleted the battery-custom-tooltip branch January 18, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants