fix(wlr/taskbar): do not bind to unsupported protocol versions #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not allowed to bind to a higher version of a wayland protocol than supported by the client. Binding wlr-foreign-toplevel-manager-v1 v3 to a generated code for v2 causes errors in libwayland due to a missing handler for `zwlr_foreign_toplevel_handle_v1.parent` event.
Alexays
approved these changes
Oct 25, 2020
|
Thanks for the fix Aleksei! |
|
Everything solved! Thanks that was fast! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not allowed to bind to a higher version of a wayland protocol than supported by the client. Binding wlr-foreign-toplevel-manager-v1 v3 to a generated code for v2 causes errors in libwayland due to a missing handler for
zwlr_foreign_toplevel_handle_v1.parentevent.This PR just allows to run waybar on the compositors with newer protocols. Someone else will have to update the protocol file, read swaywm/wlr-protocols#52 and add
zwlr_foreign_toplevel_handle_v1.parentevent support for detecting window stacks and allowing to ignore child windows in the taskbar. Wayfire git master already supports sending the event and could be used for testing.Note: I'm using interface version instead of the constant
2because I'm assuming that whoever updates the protocol file would add a handler for theparentevent in the same PR. Doing only the former would make waybar crash again.Fixes #897