-
Notifications
You must be signed in to change notification settings - Fork 67
v23 run generate analysis files (1/n) #1631
Conversation
@jharenza the CI file-related updates should go into a different PR ( |
Oh let me remove those, I think that was leftover from my testing that script in a different branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I will wait to hear back from you about the MAF changes. I expect many of the changes are related to the independent specimen files, including those to the fusion results because of:
OpenPBTA-analysis/analyses/fusion_filtering/06-recurrent-fusions-per-histology.R
Lines 59 to 61 in aa54a95
# remove samples which have WGS/WXS because those would have been captured from the independent-wgswxs-sample | |
clinical_rna_v2<-clinical %>% | |
dplyr::filter(experimental_strategy == "RNA-Seq",!Kids_First_Participant_ID %in% clinical_wgs$Kids_First_Participant_ID) |
However, the new EWSR1--FLI1 fusion in a specimen that was already captured in the recurrent fusions file surprised me?
analyses/fusion_filtering/results/pbta-fusion-recurrent-fusion-bysample.tsv
Show resolved
Hide resolved
unzipped mafs are identical:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes seem to be expected. The zip file change (i.e., the GISTIC results) makes sense since other file attributes are probably being included, regardless of whether or not the underlying results change.
I would not merge this yet, I would wait until all the PRs that will be stacked on this branch are merged into this branch first.
* v23 tp53 score * V23 mb subtyping (3/n) (#1634) * V23 MB subtyping * v23 epn add YAP1--MAML2 to fusions list and YAP1 calling, rerun (4/n) (#1638) * v23 epn add YAP1--MAML2 to fusions list and YAP1 calling, rerun * v23 chordoma (updating to 5/n) (#1635) (#1647) * v23 chordoma * v23 ews, neurocytoma, hgg (updating to 6/n) (#1636) * v23 ews, neurocytoma, hgg * v23 LGG (updating to 7/n) (#1637) * v23 LGG * v23 LGG * V23 compile (8/n) (#1639) * v23 compile * V23 integrate (9/n) (#1640) * add aliquot extraction status files and code * add extraction type to histology file * add comments to code * update README * add table of counts * remove old input file * add notebook output /rerun * add all RNA samples with NA for extraction type * add 00- to bash script, use base hist, rerun response to review Co-Authored-By: Jaclyn Taroni <19534205+jaclyn-taroni@users.noreply.github.com> Co-authored-by: Jaclyn Taroni <19534205+jaclyn-taroni@users.noreply.github.com> Co-authored-by: Jaclyn Taroni <19534205+jaclyn-taroni@users.noreply.github.com> Co-authored-by: Jaclyn Taroni <19534205+jaclyn-taroni@users.noreply.github.com> Co-authored-by: Jaclyn Taroni <19534205+jaclyn-taroni@users.noreply.github.com> Co-authored-by: Jaclyn Taroni <19534205+jaclyn-taroni@users.noreply.github.com> Co-authored-by: Jo Lynne Rokita <jolynnerokita@d3b.center> Co-authored-by: Jaclyn Taroni <19534205+jaclyn-taroni@users.noreply.github.com> Co-authored-by: Jaclyn Taroni <19534205+jaclyn-taroni@users.noreply.github.com> Co-authored-by: Jaclyn Taroni <19534205+jaclyn-taroni@users.noreply.github.com>
Purpose/implementation Section
What scientific question is your analysis addressing?
Prep for v23 release
What was your approach?
Run
generate-analysis-files.sh
for V23What GitHub issue does your pull request address?
NA
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Is there anything that you want to discuss further?
Will look into the changes in files to see if something is strikingly wrong or maybe a change was missed previously.
Update: these look ok, mainly due to updates in independent specimens and notebook HTML files. The
cnv_consensus.tsv
file has changed, but the final CNV files used in release do not change:I am going to investigate the SNV consensus maf changes, but my hunch is the row ordering is the cuplrit because I would also not expect those to change.
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
yes
Results
What types of results are included (e.g., table, figure)?
What is your summary of the results?
Files being updated in release:
Reproducibility Checklist
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up to date.