Onedark nordic, visual highlight difficult to see

[speri203]

When highlighting in visual mode the background of what is being highlighted is impossible to see. In the screenshot the ASCI art is highlighted in visual mode its almost impossible to distinguish from the background. Could the highlighting color be changed? If so, what is the procedure to do so?

[AlexvZyl]

Yeah, that looks bad. The Onedark theme was something I quickly experimented with, in an attempt to reduce the overall blue of the Nord palette. It still needs a lot of work.

Here are a few things you can try:

require 'nordic' .setup {
    theme = 'onedark',
    cursorline = {
        theme = 'dark',
    }
}

require 'nordic' .setup {
    theme = 'onedark',
    override = {
        CursorLine = {
            bg = '#000000',  -- Choose a color you like.
            bold = true -- Or false.
        }
    }
}

[AlexvZyl]

Please leave this issue open, as this is something that I want to fix.

[speri203]

Yeah, that looks bad. The Onedark theme was something I quickly experimented with, in an attempt to reduce the overall blue of the Nord palette. It still needs a lot of work.

Here are a few things you can try:

require 'nordic' .setup {
    theme = 'onedark',
    cursorline = {
        theme = 'dark',
    }
}

require 'nordic' .setup {
    theme = 'onedark',
    override = {
        CursorLine = {
            bg = '#000000',  -- Choose a color you like.
            bold = true -- Or false.
        }
    }
}

You were partially correct, it looks like what I was looking for was the "Visual" parameter and not the "CursorLine". I was able to update the visual selection and the end result of the config is as such

return {
  "AlexvZyl/nordic.nvim",
  lazy = false,
  priority = 1000,
  config = function()
    require("nordic").setup {
      theme = "onedark",
      bold_keywords = true,
      onedark = {
        brighter_whites = true,
      },
      override = {
        Visual = {
          bg = "#3A515D", -- Choose a color you like.,
          bold = false,   -- Or false.,
        },
      },
      noice = {
        style = "flat",
      },
      telescope = {
        style = "flat",
      },
    }
  end,
}

The visual mode selection is now looking like this:

[AlexvZyl]

Ah, of course. Apologies for the wrong information, it has been a while since I last worked on the plugin (finishing my thesis). Should start fixing things again quite soon.

[AlexvZyl]

The reason I got confused with CursorLine, is because Visual uses the same color internally. You might still want to keep CursorLine overridden as well.

[AlexvZyl]

Since you are the first person (other than me) that opted for the Onedark theme, what is your opinion on the idea?

[speri203]

Since you are the first person (other than me) that opted for the Onedark theme, what is your opinion on the idea?

No worries, firstly, good luck with your thesis! I looked through your published papers on GitHub. Most went over my head but it's very interesting.

I did experiment with the CursorLine as well but I find the styling a bit odd. Having the entire row highlighted is not very aesthetically pleasing and presents "redundant" information since the cursor itself is highlighted in bright red. I don't find that having the entire line highlighted gives meaningful information in my personal opinion (illustrated in the screenshot). In my workflow, if I want to make any meaningful change to a block of code then I would like to see what I am performing the action on at a quick glance whereas the cursor is enough information for when I am trying to get to a particular location within the line.

The highlight color I used for the "Visual" mode was pulled from the config of EverForest for testing purposes since I had the palette saved locally. When I get some free time I can utilize the nordic palette to see which makes sense, especially with respect to displaying comments clearly in Visual mode.

[AlexvZyl]

No worries, firstly, good luck with your thesis!

Thank you!

I don't find that having the entire line highlighted gives meaningful information in my personal opinion

Now that you mention it, I could add an option that removes the CursorLine highlight.

Since you are the first person (other than me) that opted for the Onedark theme, what is your opinion on the idea?

When I asked this, I was actually referring to the mixing of the Nord and Onedark colors.

[speri203]

When I asked this, I was actually referring to the mixing of the Nord and Onedark colors.

My fault, I absolutely love the onedark variant. What originally drew me to the onedark + nordic is the fact that the background is slightly darker in color. I have always shied away from nordic because of the overall gray tone that the theme gives off. This onedark implementation is a nice breath of fresh air on nordic in my personal opinion. Also did some messing around with the highlight coloring and found that the red gives a nice contrast between the text/comment color so they are still easily visible.

[AlexvZyl]

Hi @speri203, are you still using this theme? I am considering removing the onedark variant to reduce the maintenance surface for myself.

[speri203]

Yes, I am. Sorry for the delayed response. I am currently out of the country and don't have access to my phone for 2FA. I am locked out of Github. I understand where you are coming from and I have no problem switching to the regular Nordic variant. I use the OneDark variant due to the background color more suiting what I like but I can easily override this on the normal version. Keep up the good work and I wish you the best of luck on your thesis defense!

…

On Sun, Jun 25, 2023 at 5:20 PM Alexander van Zyl ***@***.***> wrote: Hi @speri203 <https://github.com/speri203>, are you still using this theme? I am considering removing this to reduce the maintenance surface for myself. — Reply to this email directly, view it on GitHub <#49 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIZIMP56HI63HZBS6GMHU3DXNAQXZANCNFSM6AAAAAAWGHTYLY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- *-- Sai Peri*

[AlexvZyl]

Keep up the good work and I wish you the best of luck on your thesis defense!

Thank you!

I decided to no longer maintain this theme, but you could this, it's something I am working on:

require 'nordic' .setup {
    swap_backgrounds = true
    cursorline = { theme = 'light' },
}

[speri203]

I have tried these two settings but don’t notice anything different. Are they supposed to be run on the onedark variation?Sent from my iPhoneOn Jul 6, 2023, at 6:57 PM, Alexander van Zyl ***@***.***> wrote: Keep up the good work and I wish you the best of luck on your thesis defense! Thank you! You could this, something I am working on: require 'nordic' .setup { swap_backgrounds = true cursorline = { theme = 'light' }, } —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

[AlexvZyl]

Just tested that config on my system, it works. Do you have the latest version?

[speri203]

What do these two config settings do exactly? Maybe they are working but I am just not looking for it. My config looks like this and I am currently on commit: ec2936c return { "AlexvZyl/nordic.nvim", lazy = true, priority = 1000, config = function() require("nordic").setup { theme = "nordic", bold_keywords = true, bright_border = true, swap_background = true, cursorline = { theme = "light" }, onedark = { brighter_whites = true, }, override = { Visual = { -- bg = "#BF616A", -- Choose a color you like., bg = "#B46950", -- bg = "#5E81AC", bold = true, -- Or false., }, CursorLineNr = { fg = "#fabd2f", bold = true, }, }, noice = { style = "flat", }, telescope = { style = "flat", }, } end, }

…

On Jul 10, 2023, at 10:03 PM, Alexander van Zyl ***@***.***> wrote: Just tested that config on my system, it works. Do you have the latest version? — Reply to this email directly, view it on GitHub <#49 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIZIMP2CZWAEE4ZU572BXU3XPQVGHANCNFSM6AAAAAAWGHTYLY>. You are receiving this because you were mentioned.

[AlexvZyl]

It is swap_backgrounds (plural), not swap_background (singular).

[speri203]

Ahh I got you, looks incredible, thank you for the change!

…

On Jul 11, 2023, at 6:31 PM, Alexander van Zyl ***@***.***> wrote: It is swap_backgrounds (plural), not swap_background (singular). — Reply to this email directly, view it on GitHub <#49 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIZIMP4BOFTIMCREV6CMUYLXPVFCFANCNFSM6AAAAAAWGHTYLY>. You are receiving this because you were mentioned.