Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(diff): fix diff foreground color #4

Merged
merged 3 commits into from
Jan 22, 2023
Merged

Conversation

kuntau
Copy link
Contributor

@kuntau kuntau commented Jan 22, 2023

Before

Screenshot 2023-01-23 at 3 32 52 AM

After

Screenshot 2023-01-23 at 4 54 32 AM

Fix #3

@AlexvZyl
Copy link
Owner

Thanks for the PR! Though, I now regret making the diff colors the bright versions of the palette. I do not think it looks good.

(Red and green is bright and yellow is base, since yellow generally seems brighter in this palette)

@kuntau
Copy link
Contributor Author

kuntau commented Jan 22, 2023

Or just reverse to use without background color whichever you prefer. This way a bit harder to see change and text change

Screenshot 2023-01-23 at 5 12 33 AM

@kuntau
Copy link
Contributor Author

kuntau commented Jan 22, 2023

Thanks for the PR! Though, I now regret making the diff colors the bright versions of the palette. I do not think it looks good.

(Red and green is bright and yellow is base, since yellow generally seems brighter in this palette)

Yes, I have tried using the dim version here, and white~ delete fg
Screenshot 2023-01-23 at 5 17 18 AM

@AlexvZyl
Copy link
Owner

Dim looks better, but I think specific colors should be added for the diff.

@AlexvZyl
Copy link
Owner

AlexvZyl commented Jan 22, 2023

This is fine for now, at least it is readable. I will add colors specifically designed for diff in the morning.

@AlexvZyl AlexvZyl merged commit 8148a8b into AlexvZyl:main Jan 22, 2023
@kuntau kuntau deleted the fix-diff branch January 22, 2023 21:35
@kuntau
Copy link
Contributor Author

kuntau commented Jan 22, 2023

Thank you!

@AlexvZyl AlexvZyl added the Bug / Poor Colors Something isn't working, unusable or badly designed label Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug / Poor Colors Something isn't working, unusable or badly designed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text unreadable/unusable with diffing plugins
2 participants