Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ISAPI 2 Way Audio #332

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Fix ISAPI 2 Way Audio #332

merged 1 commit into from
Apr 14, 2023

Conversation

acardace
Copy link
Contributor

@acardace acardace commented Apr 4, 2023

While testing my HikVision doorbell for 2 way audio I noticed that it wasn't working as the isapi stream would never get opened, this patch fixes it by not letting go2rtc close the producer if senders are present as well.

I don't know if this fix is correct but I tested it on my setup and it opens and closes the isapi "session" correctly.

Signed-off-by: Antonio Cardace <acardace@redhat.com>
@AlexxIT AlexxIT merged commit 5c657d5 into AlexxIT:master Apr 14, 2023
@AlexxIT AlexxIT added this to the v1.3.2 milestone Apr 14, 2023
@AlexxIT
Copy link
Owner

AlexxIT commented Apr 14, 2023

Thanks! I'm also don't know if this fix correct. But we will se.

@AlexxIT
Copy link
Owner

AlexxIT commented Apr 17, 2023

@pergolafabio
Copy link

pergolafabio commented Feb 1, 2024

Hey @acardace @AlexxIT , sorry to bump into this..
I use this isapi already for a long time, I was even the beta tester :-)

Anyway, what I notice, I use the frigate card to toggle two way audio with the mic button, it works perfectly!!

My hikvision device is also an intercom, so what I do, on an incoming call, I send an curl command to the hikvision device to stop the ringing, that way I can start two way audio... This works...

But it only works for 1 time, on the next call , i send the same curl, but I'm unable to open the two way audio...

I think the incoming call kills the isapi audio data, I think frigate/go2rtc still believes the audio session is still open, that's why I can't send audio anymore...

I need to refresh the page with the Lovelace card to make it work again... Probably then refresh opens a new audio channel?

Can this be fixed somehow?

@AlexxIT
Copy link
Owner

AlexxIT commented Feb 1, 2024

I don't know how Frigate card works. WebRTC card allow you to setup different stream for mic
https://github.com/AlexxIT/WebRTC#two-way-audio

@pergolafabio
Copy link

yeah, i now tested the webrtc card, and that does work, switching modes always provides me the two way audio
However switching the mic button on the frigate card (same as swithcing mode) doesnt start a new session

My guesst; when you switch modes on the webrtc card, it does a full refresh of the card maybe? starting a new audio session?

@AlexxIT
Copy link
Owner

AlexxIT commented Feb 1, 2024

Switching stream in the WebRTC card starts new session. This is made for fixing your issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants