ACS-8255: Migrate InfoDrawer component to Standalone #9846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenysVuika
changed the title
|
MichalKinas
approved these changes
Jun 21, 2024
| export class FileViewModule { | ||
|
|
||
| } | ||
| export class FileViewModule {} |
There was a problem hiding this comment.
Should the module be marked depracated now since the component is standalone?
There was a problem hiding this comment.
it's still used in many places, and will raise a lot of linting warnings with Sonar for all PRs, so will gradually cleanup the imports and then mark as deprecated as soon as we don't use it
swapnil-verma-gl
approved these changes
Jun 21, 2024
mauriziovitale
added a commit
that referenced
this pull request
Jun 25, 2024
mauriziovitale
added a commit
that referenced
this pull request
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
What is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
https://hyland.atlassian.net/browse/ACS-8255