Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIO share-amp resource loading bean ID should be dynamic #344

Closed
binduwavell opened this issue Nov 6, 2015 · 3 comments
Closed

AIO share-amp resource loading bean ID should be dynamic #344

binduwavell opened this issue Nov 6, 2015 · 3 comments
Assignees
Milestone

Comments

@binduwavell
Copy link

Use the 2.1.0 or 2.1.1 AIO archetype to generate a project accepting all default parameters.

Expect the bean for loading resources in .../share-amp/src/main/amp/config/alfresco/web-extension/custom-slingshot-application-context.xml to have the following id: ${project.artifactId}.resources

Actually it has the expanded name: org.alfresco.share-amp.resources.

Rational for this is that it helps make renaming the generated share-amp modules easier. Also it is consistent with how similar things are done elsewhere in the AIO archetype.

Here is a copy of what is currently generated:

   <bean id="org.alfresco.share-amp.resources"
         class="org.springframework.extensions.surf.util.ResourceBundleBootstrapComponent">
      <property name="resourceBundles">
         <list>
            <value>alfresco.web-extension.messages.custom</value>
         </list>
      </property>
   </bean>
@binduwavell
Copy link
Author

I should have mentioned that custom-slingshot-application-context.xml in AIO 2.1.0 was renamed to ${project.artifactId}-slingshot-application-context.xml in AIO 2.1.1. I think the comments about the bean id still hold :)

@ohej ohej added this to the 2.2.0 milestone Jan 11, 2016
@gravitonian
Copy link
Contributor

@gravitonian gravitonian self-assigned this Jan 12, 2016
@gravitonian
Copy link
Contributor

Fixed, all bean ids in repo and share amps now have standard ${artifactId}. prefix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants