Make udp optionals

[soullivaneuh]

Currently, both http and upd client/database instances are created, even if we don't needed.

Maybe we could make it optional with the config:

influx_db:
    connections:
        telegraf:
            host: '%influxdb_host%'
            database: '%influxdb_telegraf_db%'
            udp: false # Disable UDP

Both udp and http port would be false by default and a configuration validation could check if at least one of them is enabled.

Edit: Only udp will be optional: #36 (comment)

What do you think?

[soullivaneuh]

Doing this is BC break, so I think this should be done before 2.0.0 release.

[Algatux]

I don't like to much enabling or disabling base services of the bundle, instead of enabling/disabling them. what if we make them lazy ?

http://symfony.com/doc/current/components/dependency_injection/lazy_services.html

[soullivaneuh]

Will take a look.

[soullivaneuh]

This will be not useful at all, because connection definition require Client instanciation:

influxdb-bundle/src/Services/ConnectionFactory.php

Line 58 in c234180

$client = new Client($host, $httpPort, $user, $password);

So even if the services are lazy loaded, we will have useless Client instances.

So the only way is the way I described on my issue AFAIK.

If you prefer to keep both udp and http services, then close the issue.

[Algatux]

It will be confusing if users make use of events.
Can we deny use of soecific event if related client is not enabled?

[soullivaneuh]

Can we deny use of soecific event if related client is not enabled?

What do you mean by deny? I think the listener could simply ignore them.

If you think it's too complex, so we can just leave it as is.

[Algatux]

Or the listener may trow an exception ...

[soullivaneuh]

Or the listener may trow an exception ...

That's an idea. 👍

[soullivaneuh]

@Algatux Since #42, the http connection is required too.

I think the http connection should always be provided, and the udp optional.

This is basically the same way on the core library: https://github.com/influxdata/influxdb-php#writing-data-using-udp

An http instance is create first, then you change the driver for the UDP one.