Generated code for composition in subpart and incident
#109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
==========================================
+ Coverage 91.71% 91.81% +0.10%
==========================================
Files 22 22
Lines 1918 1943 +25
==========================================
+ Hits 1759 1784 +25
Misses 159 159 ☔ View full report in Codecov by Sentry. |
jpfairbanks
approved these changes
Feb 15, 2024
|
@jpfairbanks good to merge? |
|
Slick use of comptime @slwu89!! |
epatters
changed the title
subpart and incident
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #9 and #16. This is quite a simple PR, just moving the binary operation out of
foldlandfoldrfrom subpart and incident into a generated loop. Happy for comments!I note that the somewhat aesthetically displeasing
ifstatement in the generated method is becauseTuple{Symbol}or evenTuple{Vararg{Symbol,1}}is ambiguous when competing withTuple{Vararg{Symbol}}.[NOTE] codecov report seems to have false positives. The new tests include testing for errors when the user provides a tuple of arrows that do not compose.