Incremental hom search #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
==========================================
+ Coverage 84.10% 85.30% +1.20%
==========================================
Files 30 31 +1
Lines 1793 1926 +133
==========================================
+ Hits 1508 1643 +135
+ Misses 285 283 -2 ☔ View full report in Codecov by Sentry. |
kris-brown
force-pushed
the
incremental_homsearch
branch
from
edb0a74
to
604013d
Compare
kris-brown
force-pushed
the
incremental_homsearch
branch
from
604013d
to
d96263d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea behind this PR is described in this blog post.
An implementation of incremental hom search for DenseParts ACSets. It should be possible to extend this to MarkAsDeleted.
Waiting for a modification to HomSearch to be merged into Catlab.
A helper function here might be of interest:
connected_acset_componentsbreaks an ACSet into connected components, represented as a coproduct and an isomorphism from the original ACSet into the colimit apex.