Reimplement substitution and encapsulation of wiring diagrams to preserve box order #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Towards #39. Not working! Breaks on instantaneous wires.
Also, rename internal data structures `PortEdgeData` to `PortData` and `WireEdgeData` to `WireData`.
The encapsulation procedure has been completely rewritten, in what I hope is better style than before. Closes #55.
These functions are not actually mutating anymore. Although they might be included for backwards compatibility, I think it better to just remove them.
Provides a non-mutating, box order-preserving alternative to `rem_boxes!`.
epatters
referenced
this pull request
in epatters/semanticflowgraph
Nov 21, 2019
epatters
referenced
this pull request
in epatters/flowgraphs
Nov 21, 2019
https://github.com/epatters/Catlab.jl/pull/56 IBM/semanticflowgraph@04649fc Due to these changes, semantic enrichment now preserves the order of boxes, making the tests easier to write and understand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #39 and #55 by reimplementing
substitute!(now non-mutating and calledsubstitute) andencapsulate!(now non-mutating and calledencapsulate). Also exposesencapsulated_subdiagramas an exported function and addsinduced_subdiagramas a non-mutating alternative torem_boxes!.