Acset transformations between dynamic acsets #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 14, 2023 18:53
calling with T requires there to be a constructor that has all of its type parameters instantiated. However StructTightACSetTransformation only has a constructor for S explicitly provided
Review ChecklistDoes this PR follow the development guidelines? Following is a partial checklist: Tests
Documentation
Other
|
epatters
changed the title
epatters
requested changes
Mar 15, 2023
epatters
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the Struct vs Dynamic acset paradigm to include morphisms. Many features are still not covered for DynamicACSet categories, but this is a starting point. The goal of this PR was to be able to construct and compose maps between DynamicACSets.