Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum common sub-C-set #777

Merged
merged 9 commits into from
May 24, 2023
Merged

Maximum common sub-C-set #777

merged 9 commits into from
May 24, 2023

Conversation

mehalter
Copy link
Member

@mehalter mehalter commented May 16, 2023

Implements a general purpose algorithm for calculating Most Common Sub C-Set

@github-actions
Copy link
Contributor

github-actions bot commented May 20, 2023

Review Checklist

Does this PR follow the development guidelines? Following is a partial checklist:

Tests

  • New features and bug fixes have unit tests
  • New modules have tests that are ultimately called by the test runner (test/runtests.jl)
  • Existing tests have not been deleted
  • Code coverage >= 90% or reduction justified in PR

Documentation

  • All exported functions, types, and constants have docstrings, written in complete sentences
  • Citations are given for any constructions, algorithms, or code drawn from external sources

Other

  • Style guidelines are followed, including indent width 2
  • Changes breaking backwards compatibility have been approved

@epatters epatters changed the title Add Maximum Common C-Set implementation Maximum common sub-C-set May 22, 2023
Copy link
Member

@epatters epatters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice PR! I especially appreciate the thorough tests.

I left a few small comments below.

src/acsets/DenseACSets.jl Outdated Show resolved Hide resolved
src/acsets/DenseACSets.jl Outdated Show resolved Hide resolved
src/categorical_algebra/CSets.jl Outdated Show resolved Hide resolved
src/categorical_algebra/CSets.jl Outdated Show resolved Hide resolved
src/categorical_algebra/CSets.jl Outdated Show resolved Hide resolved
src/categorical_algebra/CSets.jl Outdated Show resolved Hide resolved
src/categorical_algebra/CSets.jl Outdated Show resolved Hide resolved
src/categorical_algebra/CSets.jl Outdated Show resolved Hide resolved
src/categorical_algebra/CSets.jl Outdated Show resolved Hide resolved
@mehalter mehalter force-pushed the mca branch 2 times, most recently from 4a17788 to 9734af2 Compare May 24, 2023 00:12
mehalter and others added 3 commits May 23, 2023 20:12
Co-authored-by: p-stokes <patrick.stokes@gmail.com>

Also adds an mca test with graphs, but there may be an issue with the identified the morphisms.
Commented MCA code which needs to be integrated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants