-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maximum common sub-C-set #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehalter
force-pushed
the
mca
branch
2 times, most recently
from
May 17, 2023 00:23
18a057d
to
6beb59b
Compare
mehalter
changed the title
ENH: Add Maximum Common C-Set implementation
Add Maximum Common C-Set implementation
May 18, 2023
This was referenced May 18, 2023
Review ChecklistDoes this PR follow the development guidelines? Following is a partial checklist: Tests
Documentation
Other
|
epatters
changed the title
Add Maximum Common C-Set implementation
Maximum common sub-C-set
May 22, 2023
epatters
requested changes
May 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice PR! I especially appreciate the thorough tests.
I left a few small comments below.
epatters
approved these changes
May 23, 2023
mehalter
force-pushed
the
mca
branch
2 times, most recently
from
May 24, 2023 00:12
4a17788
to
9734af2
Compare
Co-authored-by: p-stokes <patrick.stokes@gmail.com> Also adds an mca test with graphs, but there may be an issue with the identified the morphisms.
Commented MCA code which needs to be integrated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a general purpose algorithm for calculating Most Common Sub C-Set