Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Brian Kernighan's algorithm. #43

Closed
wants to merge 4 commits into from
Closed

Added Brian Kernighan's algorithm. #43

wants to merge 4 commits into from

Conversation

debanjan-2002
Copy link
Contributor

@debanjan-2002 debanjan-2002 commented Feb 18, 2021

Sir,
I have added Brian Kernighan's algorithm in the Bit Manipulation section. I have explained it very briefly and given the reasoning and intuition behind the algorithm. Please review my pull request, and if you like how I explain then please consider merging it.
I have also been selected in GSSOC'21, and I am really into DSA. So it would be a really kind of you if you give me the opportunity to contribute in this amazing repository.

Regards,
Debanjan Poddar

Copy link
Member

@vatsalkesarwani12 vatsalkesarwani12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only 1 issue to be solved in one or

Remove Sieve code and add another for that

#include<bits/stdc++.h>
using namespace std;

// Brian Kernighan's Algorithm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bring this comment on top of the file

Code/C++/Brian_Kernighan.cpp Show resolved Hide resolved
@vatsalkesarwani12
Copy link
Member

Also, update the readme file for that

using namespace std;


/* It is an algorithm developed to count the number of set bits in a number
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bring this comment outside the main code

@vatsalkesarwani12
Copy link
Member

Also please link your pr with the issue

@raksha009 raksha009 added the inactive inactive participation label Apr 12, 2021
@raksha009 raksha009 closed this Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inactive inactive participation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants