Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hook up custom readers #227

Merged
merged 50 commits into from
Mar 14, 2020
Merged

Hook up custom readers #227

merged 50 commits into from
Mar 14, 2020

Conversation

c-harris
Copy link
Member

will provide the reading support for odata objects into the object Model

@coveralls
Copy link

coveralls commented Mar 13, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 97.492% when pulling 2db8a8b on c-harris:Readers into be72f03 on Algo-Web:master.

@c-harris @CyberiaResurrection
Add first cut at an atom reader and a test
83303e4 
Because I'm using rather low level xml stuff (xml parser is the very bottom of ext-xml),
I didn't want to risk interactions with mockery, because errors could be a pain in the butt to debug.

(Put a dd in the entity processor and watch it state "can not free xml parser while parsing in progress")
@c-harris @CyberiaResurrection
Add reader registry to the base service
d4d8bb8
@c-harris @CyberiaResurrection
Get the reader registry working
b01426e
@c-harris @CyberiaResurrection
Provide the reader registry to the request description
d56d395
@c-harris @CyberiaResurrection
Remove JMS - the various readers subsume its functionality
c5f4861
@c-harris @CyberiaResurrection
attempt to fix mockery issues
95d5b87
@c-harris @CyberiaResurrection
changes for test fixes
9fb9927
@CyberiaResurrection CyberiaResurrection changed the title WIP: Readers Hook up custom readers Mar 14, 2020
@CyberiaResurrection CyberiaResurrection merged commit b6ccc1e into Algo-Web:master Mar 14, 2020
@CyberiaResurrection CyberiaResurrection deleted the Readers branch March 14, 2020 15:29
@CyberiaResurrection CyberiaResurrection mentioned this pull request Mar 15, 2020
Closed
@c-harris c-harris mentioned this pull request May 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyberiaResurrection CyberiaResurrection CyberiaResurrection left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@c-harris @coveralls @CyberiaResurrection